BDMS-540: Add missing thing_id foreign key to NMA_WeatherData#468
Merged
jirhiker merged 8 commits intokas-bdms-540-standardize-PKs-FKsfrom Feb 7, 2026
Merged
Conversation
…ablish relationship with Thing - add thing_id FK + relationship on NMA_WeatherData with validation - cache Thing.nma_pk_location and resolve thing_id in WeatherData transfer - skip unlinked WeatherData rows to prevent orphaned children - add alembic migration to backfill thing_id and enforce NOT NULL - update WeatherData legacy tests to include Thing linkage
ksmuczynski
requested review from
TylerAdamMartinez,
jacob-a-brown,
jirhiker and
kbighorse
…os and NMA_SurfaceWaterData via SurfaceID - make NMA_SurfaceWaterData.surface_id unique to support FK target - add FK + relationship on NMA_SurfaceWaterPhotos.surface_id with validation - enforce parent-first ordering by running SurfaceWaterPhotos after SurfaceWaterData - skip orphan photo rows in transfer using cached SurfaceIDs - add migration to backfill/cleanup and enforce NOT NULL + FK - update legacy tests to create photos with real parent SurfaceWaterData
…NMA_WeatherPhotos via WeatherID - move weather_id under FK section and enforce NOT NULL - add FK + relationship + validator on NMA_WeatherPhotos - mark NMA_WeatherData.weather_id unique for FK target - run WeatherPhotos transfer after WeatherData and skip orphan photos - add migration to backfill/cleanup and enforce FK/NOT NULL - update legacy tests to create WeatherPhotos with a real parent WeatherData
…atherPhotos-FK-relationship BDMS-540: Link NMA_WeatherPhotos to NMA_WeatherData
…rfaceWaterPhotos-FK-relationship BDMS-540: Link NMA_SurfaceWaterPhotos to NMA_SurfaceWaterData
TylerAdamMartinez
deleted the
kas-bdms-540-NMA_WeatherData-FK-relationship
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
thing_idrelationship for NMA WeatherData to ensure legacy rows link to Thing records and avoid orphaned childrenHow
Implementation summary - the following was changed / added / removed:
thing_idby matching each row’s location toThing.nma_pk_location, linking NMA_WeatherData → Thing and skipping rows without a match to avoid orphaned records.thing_idand enforce NOT NULLNotes
Any special considerations, workarounds, or follow-up work to note?